[PATCH] D52444: [DWARF] Make llvm-dwarfdump display the .debug_loc.dwo section (fixes PR38991)

[David Blaikie via Phabricator via llvm-commits]

dblaikie accepted this revision.
dblaikie added inline comments.


================
Comment at: test/tools/llvm-dwarfdump/X86/debug_loc_dwo.ll:5-6
+
+; Make sure llvm-dwarfdump can display a location list in a split dwarf context
+; (i.e. in the .debug_loc.dwo section).
+;
----------------
I think this is already tested - in, say, test/DebugInfo/X86/fission-ranges.ll

I think you can probably skip this test case - and just keep the other one that's testing the new functionality you're enabling?


================
Comment at: test/tools/llvm-dwarfdump/X86/debug_loc_dwo.s:15
+# end_of_list), which is what llvm generates as well. llvm-dwarfdump just dumps the
+# index without interpreting it any further.
+.byte 3          # DW_LLE_startx_length
----------------
What further interpretation of the address index could it do?


https://reviews.llvm.org/D52444