[PATCH] D52241: Eliminate .{, z}debug_gnu_pub{names, types} sections as early as possible.

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

In https://reviews.llvm.org/D52241#1251854, @MaskRay wrote:

> The gdb command `save gdb-index` can produce `symbol-file.gdb-index`, but it seems it does not need `.debug_gnu_pub{names,types}`


Doesn't need it - but the data can be used (not sure if GDB does use it, admittedly - but the data is meaningful even without a linker index builder) so it seems a bit weird to me to have the linker silently strip it out.

In https://reviews.llvm.org/D52241#1254358, @ruiu wrote:

> I'll submit this patch soon if there's no further comment.


Still feels strange to me to strip a perfectly usable section silently like this. If the user doesn't want these sections they can pass -gno-pubnames to the compiler and avoid generating them in the first place.


https://reviews.llvm.org/D52241