[PATCH] D51276: [New PM][PassTiming] implement -time-passes for the new pass manager

[Fedor Sergeev via Phabricator via llvm-commits]

fedor.sergeev marked 7 inline comments as done.
fedor.sergeev added inline comments.


================
Comment at: lib/Passes/StandardInstrumentations.cpp:111
     PassInstrumentationCallbacks &PIC) {
+  // print-before instrumentation
   if (llvm::shouldPrintBeforePass())
----------------
chandlerc wrote:
> fedor.sergeev wrote:
> > philip.pfaffe wrote:
> > > I don't think these comments here actually add anything.
> > if you grep the sources for the name of the option you will find this.
> > Other than that - yes, it does not add anything to the code readability.
> Maybe if they were full prose it would be more clear? As it is, these are I think mostly helpful given context that you have implicitly in your head. I suspect expanding them into prose will either make them both clear and useful to readers, or will make it more obvious that they are just repeating what the code already clearly states it is doing.
Oh, well, perhaps I better strip them off... nothing really important "implicitly in my head" :)


Repository:
  rL LLVM

https://reviews.llvm.org/D51276