[PATCH] D52837: [WebAssembly] Ignore DBG_VALUE in WebAssemblyCFGStackify pass when looking for block start

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 4 08:59:30 PDT 2018


aheejin added a comment.

Thank you. Could you minimize the test so it becomes something like a unit test..? This test looks rather like generated. And I'm not sure we need all those debug values either..



================
Comment at: test/CodeGen/WebAssembly/cfg-stackify-dbg-skip.ll:6
+; of instructions that form a logical expression. In this case, the test
+; instructions contain DBG_VALUE between them.
+
----------------
How about 'stackified expression' instead of 'logical expression'?


Repository:
  rL LLVM

https://reviews.llvm.org/D52837





More information about the llvm-commits mailing list