[PATCH] D52765: [ConstantFolding] Constant fold minimum and maximum intrinsics

[Heejin Ahn via Phabricator via llvm-commits]

aheejin added inline comments.


================
Comment at: test/Analysis/ConstantFolding/min-max.ll:14
+
+; CHECK: define float @minnum_float() {
+define float @minnum_float() {
----------------
Maybe add one or two line comments about what the expectations are for each test?


================
Comment at: test/Analysis/ConstantFolding/min-max.ll:49
+}
+
+; CHECK: define float @minimum_float() {
----------------
Maybe add tests with zeros for `minnum` and `maxnum` too to show they can't be constant folded?


Repository:
  rL LLVM

https://reviews.llvm.org/D52765