[PATCH] D52866: [llvm-exegesis][NFC] Improve parsing of the YAML files
Clement Courbet via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Oct 4 01:29:53 PDT 2018
courbet added inline comments.
================
Comment at: tools/llvm-exegesis/lib/BenchmarkResult.cpp:90
+ return false;
+ static_assert(sizeof(unsigned long long) == sizeof(uint64_t), "");
+ std::memcpy(&Value, &Result, sizeof(Value));
----------------
what about adding an overload for `consumeUnsignedInteger(uint64_t)` and delegating to a `template<typename T> consumeUnsignedInteger(T)` in the cpp file ?
Repository:
rL LLVM
https://reviews.llvm.org/D52866
More information about the llvm-commits
mailing list