[PATCH] D52815: [ELF] Fix crash on invalid undefined local symbols

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai added inline comments.


================
Comment at: test/ELF/invalid-undefined-local-symbol-in-dso.s:4
+# We used to crash on this
+# RUN: ld.lld %p/Inputs/undefined-local-symbol-in-dso.so -o %t 2>&1 | \
+# RUN:   FileCheck -check-prefix=WARN %s
----------------
grimar wrote:
> Can you use yaml for the test case?
> 
> You perhaps can use obj2yaml on the file you have.
I tried using obj2yaml, but it's unable to produce a broken DSO of this nature. I need to have a local symbol in the global section of the dynamic symbol table, i.e. have a local symbol with index >= the dynamic symbol table section's `sh_info`. I don't think obj2yaml is able to produce an output file like that. I added super detailed instructions for creating the broken DSO instead.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D52815