[PATCH] D52837: [WebAssembly] Ignore DBG_VALUE in WebAssemblyCFGStacify pass when looking for block start

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 3 15:14:58 PDT 2018


aheejin added inline comments.


================
Comment at: test/CodeGen/WebAssembly/cfg-stackify-dbg-skip.ll:7
+; CHECK: i32.wrap/i64
+; CHECK: i32.eqz
+
----------------
Maybe a little comment about what this test is about would be good for future readers..? Like, why block should be placed there and where a debug instruction was in MIR. (Speaking of which, an MIR test would probably be better, but I guess this is also fine)


Repository:
  rL LLVM

https://reviews.llvm.org/D52837





More information about the llvm-commits mailing list