[PATCH] D52749: [LLD][COFF] Fix ordering of CRT global initializers in COMDAT sections

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 3 13:59:45 PDT 2018


mstorsjo added inline comments.


================
Comment at: COFF/Writer.cpp:745
 
+      // The CRT section contains, among other things, the array of function
+      // pointers that initialize every global variable that is not trivially
----------------
mstorsjo wrote:
> I'd rather have this comment above the function itself. Being this verbose (which in itself is great!) inline in a function makes you lose focus on the overall structure.
I don't see this one addressed even though you checked it as done. I meant moving the large comment to be above the function definition, not here by the function call, to keep the overall structure of `createSections` as readable as possible.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D52749





More information about the llvm-commits mailing list