[PATCH] D49795: [PPC64] Position-independent long-branch thunks.

[Rumeet Dhindsa via Phabricator via llvm-commits]

rdhindsa added inline comments.
Herald added a subscriber: jsji.


================
Comment at: ELF/SyntheticSections.h:362
   bool empty() const override;
+  void postThunkContents() override;
 
----------------
I think you need to add postThunkContents as virtual function to class SyntheticSection as well.


================
Comment at: ELF/Writer.cpp:1686
   // createThunks may have added local symbols to the static symbol table
-  applySynthetic({InX::SymTab},
+  applySynthetic({InX::GotPlt, InX::SymTab},
                  [](SyntheticSection *SS) { SS->postThunkContents(); });
----------------
Could you please rebase and update Inx::GotPlt to In.GotPlt



Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D49795