[PATCH] D52830: [ELF] - Set sh_info and sh_link for .rela.plt sections.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 3 09:16:06 PDT 2018


ruiu added a comment.

In the commit message, please emphasize that this is what ELF spec requires, rather than emphasizing that GNU tools complain.



================
Comment at: ELF/SyntheticSections.cpp:1498
+  // as the link to suppress the warnings reported by GNU tools like readelf.
+  Link = In.DynSymTab ? In.DynSymTab->getParent()->SectionIndex
+                      : In.SymTab->getParent()->SectionIndex;
----------------
Why don't you directly assign it to getParent()->Link?


https://reviews.llvm.org/D52830





More information about the llvm-commits mailing list