[PATCH] D52831: [lit] Only return a found bash executable on Windows if it can understand Windows paths

Zachary Turner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 3 08:43:12 PDT 2018


zturner added a subscriber: gbedwell.
zturner added a comment.

I personally think we should never use bash on Windows (wsl being the
exception but that won’t identify as Windows anyway). There’s value in
consistency and in my ideal world the lit shell would be feature rich
enough that we wouldn’t have to use bash *anywhere*. In any case right now
the configuration matrix is Windows (lit shell) and non Windows (bash). I
don’t think we should grow this by supporting Windows (bash)


https://reviews.llvm.org/D52831





More information about the llvm-commits mailing list