[PATCH] D52776: [OptRemarks] Add library for parsing optimization remarks

[Francis Visoiu Mistrih via Phabricator via llvm-commits]

thegameg added inline comments.


================
Comment at: lib/OptRemarks/OptRemarksParser.cpp:303
+    error("YAML parsing failed.", *Remark.getRoot());
+    return true;
+  }
----------------
thegameg wrote:
> JDevlieghere wrote:
> > So `true` means there was an error and `false` means success? That's probably worth mentioning in a comment as well. There was a discussion about this on the mailing list, but I'm not sure if anything was decided yet.
> Fair point, thanks! It seems that the [[ http://lists.llvm.org/pipermail/llvm-dev/2018-September/126178.html | discussion ]] was going more towards returning true on success. I'll update everything accordingly.
Forget that, I updated it to `llvm::Error` instead.


https://reviews.llvm.org/D52776