[PATCH] D52741: [AMDGPU] Add an AMDGPU pass to promote bitcast calls

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: lib/Target/AMDGPU/AMDGPUFixFunctionBitcasts.cpp:35
+public:
+  void visitCallInst(CallInst &CI) {
+    CallSite CS(&CI);
----------------
Should use visitCallSite to handle invokes as well


================
Comment at: lib/Target/AMDGPU/AMDGPUFixFunctionBitcasts.cpp:37-38
+    CallSite CS(&CI);
+    if (!CS.getCalledValue())
+      return;
+    if (CS.getCalledFunction())
----------------
How can this happen?


https://reviews.llvm.org/D52741