[PATCH] D52760: [SimplifyCFG] Change recursive calls to llvm::SimplifyCFG to instead call the "run" function on the SimplifyCFGOpt object

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 3 02:04:38 PDT 2018


reames added a comment.

In https://reviews.llvm.org/D52760#1253459, @craig.topper wrote:

> I definitely agree that this recursion is not the ideal way to implement this. I haven't looked closely to see if we always do this recursion or if we sometimes just return without recursing. Any issue with this patch in the short term?


I'm not actively objecting, but I'm not sure I'd bother to pursue this intermediate state as opposed to directly addressing the root issue.  If you really want to pursue this approach, I'm willing to review and signoff.


https://reviews.llvm.org/D52760





More information about the llvm-commits mailing list