[PATCH] D52815: [ELF] Fix crash on invalid undefined local symbols

[George Rimar via Phabricator via llvm-commits]

grimar added a comment.

We have a subfolder `test\ELF\invalid` for the tests that have invalid inputs. I think the test case should be placed there.



================
Comment at: test/ELF/invalid-undefined-local-symbol-in-dso.s:3
+
+# We used to crash on this
+# RUN: ld.lld %p/Inputs/undefined-local-symbol-in-dso.so -o %t 2>&1 | \
----------------
Please expand the comment to describe what is exactly wrong with the object.


================
Comment at: test/ELF/invalid-undefined-local-symbol-in-dso.s:4
+# We used to crash on this
+# RUN: ld.lld %p/Inputs/undefined-local-symbol-in-dso.so -o %t 2>&1 | \
+# RUN:   FileCheck -check-prefix=WARN %s
----------------
Can you use yaml for the test case?

You perhaps can use obj2yaml on the file you have.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D52815