[PATCH] D52759: [AMDGPU] Rename pass "isel" to amdgpu-isel

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 2 19:59:53 PDT 2018


arsenm added a comment.

In https://reviews.llvm.org/D52759#1252115, @MaskRay wrote:

> In https://reviews.llvm.org/D52759#1251949, @arsenm wrote:
>
> > Why do other targets do this? -debug already behaves weirdly since -debug prints more during SelectionDAG than -debug-only=isel, and this will make that worse?
>
>
> Other targets don't have a `*-isel` pass. I am unclear why AMDGPU has the `isel` that misguided people to do things like `-stop-after=isel` (which does not work if they don't build the AMDGPU target)


This sounds broken. The target "owns" the isel pass, so I would expect every target to call this isel, and it wouldn't matter what target you're using


Repository:
  rL LLVM

https://reviews.llvm.org/D52759





More information about the llvm-commits mailing list