[PATCH] D52805: [WebAssembly] Bitselect intrinsic and instruction

[Derek Schuff via Phabricator via llvm-commits]

dschuff added inline comments.


================
Comment at: test/CodeGen/WebAssembly/simd-arith.ll:2
 ; RUN: llc < %s -asm-verbose=false -disable-wasm-fallthrough-return-opt -wasm-disable-explicit-locals -wasm-keep-registers -wasm-enable-unimplemented-simd -mattr=+simd128 | FileCheck %s --check-prefixes CHECK,SIMD128
-; RUN: llc < %s -asm-verbose=false -disable-wasm-fallthrough-return-opt -wasm-disable-explicit-locals -wasm-keep-registers -wasm-enable-unimplemented-simd -mattr=+simd128 -fast-isel | FileCheck %s --check-prefixes CHECK,SIMD128
 ; RUN: llc < %s -asm-verbose=false -disable-wasm-fallthrough-return-opt -wasm-disable-explicit-locals -wasm-keep-registers -mattr=+simd128 | FileCheck %s --check-prefixes CHECK,SIMD128-VM
----------------
tlively wrote:
> dschuff wrote:
> > I assume you removed this because you didn't add fast-isel support? You can still keep it as long as you don' have the -fast-isel-abort flag, because if a block cannot be selected with fast-isel it will fall back to SelectionDAG.
> Good to know! I'm not sure that's useful for a test, though, since we want to be explicitly testing fast-isel or not testing it at all.
In that case we should add -fast-isel-abort to the llc command lines where we have -fast-isel. 


Repository:
  rL LLVM

https://reviews.llvm.org/D52805