[PATCH] D52748: [WebAssembly] LSDA info generation

[Derek Schuff via Phabricator via llvm-commits]

dschuff added inline comments.


================
Comment at: lib/CodeGen/AsmPrinter/WasmException.cpp:31
+  bool ShouldEmitExceptionTable = false;
+  for (const auto &Info : MF->getLandingPads()) {
+    if (MF->hasWasmLandingPadIndex(Info.LandingPadBlock)) {
----------------
Can this be `const LandingPadInfo&` instead of `const auto` for more clarity?


================
Comment at: lib/CodeGen/AsmPrinter/WasmException.cpp:42
+
+  // Wasm requires every data section symbol to have a .size set. So we emit an
+  // end marker and set the size as the difference between the start end the end
----------------
Is there some particular reason for this or is it just a limitation of our assembler and/or MC?


Repository:
  rL LLVM

https://reviews.llvm.org/D52748