[PATCH] D52799: [llvm-pdbutil] Pretty print PDBSymbolUsingNamespace symbols
Zachary Turner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Oct 2 13:49:27 PDT 2018
zturner added inline comments.
================
Comment at: tools/llvm-pdbutil/PrettyCompilandDumper.cpp:228-229
+ std::string Name = Symbol.getName();
+ if (!Name.empty())
+ WithColor(Printer, PDB_ColorItem::Identifier).get() << Name;
+}
----------------
Also I think we can drop the if statement here and write this all on line line.
```
WithColor(Printer, PDB_ColorItem::Identifier).get() << Symbol.getName();
```
If the string is empty it will just be a no-op, which is fine.
Repository:
rL LLVM
https://reviews.llvm.org/D52799
More information about the llvm-commits
mailing list