[PATCH] D50330: [RFC] Implement out-of-process allocator enumeration for macOS

Vitaly Buka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 2 11:38:46 PDT 2018


vitalybuka added inline comments.


================
Comment at: lib/sanitizer_common/sanitizer_allocator_bytemap.h:21
  public:
+  typedef FlatByteMap<kSize> ThisT;
   void Init() {
----------------
I'd avoid this typedefs use in implementation only
for sizeof please use actual variables, e.g. sizeof(*this)
other few places just decltype(*this)


https://reviews.llvm.org/D50330





More information about the llvm-commits mailing list