[PATCH] D52764: [Intrinsic] Add llvm.minimum and llvm.maximum instrinsic functions

[Thomas Lively via Phabricator via llvm-commits]

tlively added inline comments.


================
Comment at: docs/LangRef.rst:11638
+IEEE 754-2018.
+
 '``llvm.copysign.*``' Intrinsic
----------------
javed.absar wrote:
> Does this need a para on sNaN and qNaN behaviour (as above for llvm.max) ?
I don't think so. llvm.maxnum and llvm.minnum need that paragraph because backends may have the unusual responsibility to quiet input NaNs for those operations in order to match the intrinsic semantics. That is because the minNum and maxNum in IEEE 754-2008 are exceptional in their handling of sNaNs and qNaNs. In contrast, these new intrinsics have the standard NaN propagation behavior for both sNaNs and qNaNs. Backends shouldn't need to take any additional action to canonicalize NaNs to get the right results.


Repository:
  rL LLVM

https://reviews.llvm.org/D52764