[PATCH] D52741: [AMDGPU] Add an AMDGPU pass to promote bitcast calls

Scott Linder via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 2 09:45:28 PDT 2018


scott.linder added a subscriber: sbc100.
scott.linder added a comment.

After reading the WebAsm code more closely it seems like our goals are different. They seem to support indirect calls, but only if certain properties of the functions match (namely number of arguments and return type). For example, the existing pass does not transform anything (e.g. leaves a bitcast function call present) if the bitcast only modifies argument types in a trivial way. For AMDGPU we need to always eliminate the bitcast, and we don't necessarily need to be generating wrapper functions.

@sbc100 I am not sure who to ask, but you touched the WebAssemblyFixFunctionBitcasts pass recently; is my assessment of the intent of the pass accurate?


Repository:
  rL LLVM

https://reviews.llvm.org/D52741





More information about the llvm-commits mailing list