[PATCH] D52741: [AMDGPU] Add an AMDGPU pass to promote bitcast calls

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 1 19:40:02 PDT 2018


arsenm requested changes to this revision.
arsenm added a comment.
This revision now requires changes to proceed.

How does this differ from WebAssemblyFixFunctionBitcasts? Should we have a common pass for this?

The generic utils changes are also a separate patch



================
Comment at: lib/Target/AMDGPU/AMDGPUFixFunctionBitcasts.cpp:30-32
+  StringRef getPassName() const override {
+    return "AMDGPU Fix Function Bitcasts";
+  }
----------------
This can be dropped


================
Comment at: test/CodeGen/AMDGPU/call-constexpr.ll:1
+; RUN: llc -mtriple=amdgcn-amd-amdhsa -verify-machineinstrs < %s | FileCheck -check-prefix=GCN %s
+
----------------
Should have an opt run of just the pass


Repository:
  rL LLVM

https://reviews.llvm.org/D52741





More information about the llvm-commits mailing list