[PATCH] D52748: [WebAssembly] LSDA info generation

[Sam Clegg via Phabricator via llvm-commits]

sbc100 added inline comments.


================
Comment at: lib/CodeGen/AsmPrinter/EHStreamer.cpp:610
+  if (IsWasm)
+    return GCCETSym;
+
----------------
This seems a little off,  could remove that requirement?

If we can't then perhaps invert this check we we only have a single return statement?

```
if (!IsWasm)
  Asm->EmitAlignment(2);
return GCCETSym;
```


================
Comment at: test/CodeGen/WebAssembly/eh-lsda.ll:44
+; CHECK-NEXT:   .int8  0                       # @TType Encoding = absptr
+; CHECK-NEXT:   .uleb128 .Lttbase0-.Lttbaseref0
+; CHECK-NEXT: .Lttbaseref0:
----------------
Ha.. I didn't know that assembler could be used to encode LEBs like this.

I'm assuming this assembly value (i.e. doesn't generate a relocations?)


Repository:
  rL LLVM

https://reviews.llvm.org/D52748