[PATCH] D52743: [sanitizer] Include inlined frames into __sanitizer_symbolize_pc output

[Evgenii Stepanov via Phabricator via llvm-commits]

eugenis added inline comments.


================
Comment at: compiler-rt/include/sanitizer/common_interface_defs.h:127
   // Outputs at most 'out_buf_size' bytes into 'out_buf'.
+  // If 'out_buf' is not empty then output is zero or more non empty C strings
+  // followed by single empty C string. Multiple strings can be returned if PC
----------------
Mention that the frames are printed in the order from most-inlined to least-inlined.


================
Comment at: compiler-rt/include/sanitizer/common_interface_defs.h:129
+  // followed by single empty C string. Multiple strings can be returned if PC
+  // corresponds to inlinined function. This behavior is controlled with
+  // 'symbolize_inline_frames'.
----------------
typo: inlined


================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_stacktrace_libcdep.cc:126
+                common_flags()->strip_path_prefix);
+    if (!frame_desc.length())
+      continue;
----------------
what does this condition do?


Repository:
  rL LLVM

https://reviews.llvm.org/D52743