[PATCH] D52749: [LLD][COFF] Fix CRT global initializers

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added inline comments.


================
Comment at: COFF/Writer.cpp:1605
+        case 1:
+          return false;
+        case 0:
----------------
mstorsjo wrote:
> Won't this override the internal ordering based on the section name suffixes like .CRT$ABC?
Or what actually does `getBufferIdentifier()` return - the name of the object file? In that case I'd say this is wrong. If it returns the section name it might be ok...


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D52749