[PATCH] D52739: [PassManager/Sanitizer] Port of AddresSanitizer pass from legacy to new PassManager

Fedor Sergeev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 1 13:12:32 PDT 2018


fedor.sergeev added a comment.

In https://reviews.llvm.org/D52739#1251533, @philip.pfaffe wrote:

> Thank you for moving this along!
>
> You can greatly reduce this change by pulling most of the functionality out of the pass, and just wrapping it up in per-PassManager wrapper passes. You also don't have to move all that code into the header and can keep it local in the implementation.


Well, it will be a bit tricky to avoid moving the interfaces around, since AddressSanitizer contains quite a load of state, so you cant have a wrapper w/o introducing
definitions of this state other than playing tricks with indirection.
Though yes, making wrapper passes that have a pointer to opaque AddressSanitizer might do the dirty trick.


Repository:
  rL LLVM

https://reviews.llvm.org/D52739





More information about the llvm-commits mailing list