[PATCH] D52702: [X86] Standardize floating point assembly comments
Eli Friedman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 1 12:06:40 PDT 2018
efriedma added a comment.
If the output of llvm::write_double isn't consistent between Linux and Windows, we should probably fix that.
That said, this is still fine.
================
Comment at: lib/Target/X86/X86MCInstLower.cpp:2105
+ else if (CDS->getElementType()->isFloatTy() ||
+ CDS->getElementType()->isDoubleTy())
+ printConstant(CDS->getElementAsAPFloat(i), CS);
----------------
You could also check for isHalfTy(); I guess it's unlikely to be relevant on x86, though.
Repository:
rL LLVM
https://reviews.llvm.org/D52702
More information about the llvm-commits
mailing list