[PATCH] D52125: X86, AArch64, ARM: Do not attach debug location to spill/reload instructions

Mon Oct 1 11:59:50 PDT 2018

MatzeB added a comment.

In https://reviews.llvm.org/D52125#1235612, @vsk wrote:

> As Matthias points out, a spill/reload can't unambiguously be associated with a specific instruction.
>
> Note that passing an empty location means that the instruction is described by the previous .loc directive in the stream (if one is present). I think the pedantic thing to do would be to use the special "line 0" location. However, that might bloat the line table and possibly interfere with the way llvm currently identifies prologues.

What would be the difference between a "line 0" location and an empty location? They both sound like "doesn't have a corresponding location in the source" to me...

> I think this is the right approach. LGTM, although a regression test on the ARM side wouldn't hurt :).

added an aarch64 test.

Repository:
  rL LLVM

https://reviews.llvm.org/D52125