[PATCH] D52426: [X86] Move X86DAGToDAGISel::matchBEXTRFromAnd() into X86ISelLowering
Craig Topper via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 1 11:40:45 PDT 2018
craig.topper added inline comments.
================
Comment at: lib/Target/X86/X86ISelLowering.cpp:35407
+ if (SDValue R = combineShiftAndIntoBEXTR(N, DAG, Subtarget))
+ return R;
----------------
This should probably be below the LegalizeOps check. We should give ample opportunity for AND based DAG combines to optimize this.
Repository:
rL LLVM
https://reviews.llvm.org/D52426
More information about the llvm-commits
mailing list