[PATCH] D52426: [X86] Move X86DAGToDAGISel::matchBEXTRFromAnd() into X86ISelLowering

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: lib/Target/X86/X86ISelLowering.cpp:35245
+    return true;
+  }
+}
----------------
Most of this could be replaced with:
```
return (VT == MVT::i32 || (VT == MVT::i64 && Subtarget.is64Bit()));
```


================
Comment at: lib/Target/X86/X86ISelLowering.cpp:35261
+  EVT VT = Node->getValueType(0);
+  if (!VT.isSimple())
+    return SDValue();
----------------
You could just use the EVT value all the way through if you changed hasBEXTR to take an EVT instead of MVT


Repository:
  rL LLVM

https://reviews.llvm.org/D52426