[PATCH] D52709: Add -instcombine-code-sinking option

[Andy Kaylor via Phabricator via llvm-commits]

andrew.w.kaylor added a comment.

Can you update this review with a summary that describes the problem your are trying to fix by disabling instruction sinking here?



================
Comment at: lib/Transforms/InstCombine/InstructionCombining.cpp:123
+static cl::opt<bool>
+CodeSinking("instcombine-code-sinking", cl::desc("Enable code sinking"),
+                                        cl::Hidden, cl::init(true));
----------------
This could use a longer description and a comment block explaining why it's an option. I also don't think it needs to be hidden. And for consistency with similar options, I would name this variable "EnableCodeSinking".


Repository:
  rL LLVM

https://reviews.llvm.org/D52709