[PATCH] D52729: [InstCombine] Fix SimplifyLibCalls erasing an instruction while IC still had references to it

Amara Emerson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 1 09:17:18 PDT 2018


aemerson created this revision.
aemerson added reviewers: spatel, chandlerc, ab.

InstCombine keeps a worklist and assumes that optimizations don't eraseFromParent() the instruction, which SimplifyLibCalls violates. This change adds a new callback to SimplifyLibCalls to let clients specify their own hander for erasing actions.


Repository:
  rL LLVM

https://reviews.llvm.org/D52729

Files:
  include/llvm/Transforms/Utils/SimplifyLibCalls.h
  lib/Transforms/InstCombine/InstCombineCalls.cpp
  lib/Transforms/Utils/SimplifyLibCalls.cpp
  test/Transforms/InstCombine/simplify-libcalls-erased.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D52729.167750.patch
Type: text/x-patch
Size: 6706 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181001/82f16c27/attachment.bin>


More information about the llvm-commits mailing list