[PATCH] D52346: [LNT] Print machine name in LNT graph tooltip.

[Martin Liška via Phabricator via llvm-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rL343463: Print machine name in LNT graph tooltip. (authored by marxin, committed by ).
Herald added a subscriber: llvm-commits.

Changed prior to commit:
  https://reviews.llvm.org/D52346?vs=166427&id=167710#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D52346

Files:
  lnt/trunk/lnt/server/ui/static/lnt_graph.js
  lnt/trunk/lnt/server/ui/views.py


Index: lnt/trunk/lnt/server/ui/static/lnt_graph.js
===================================================================
--- lnt/trunk/lnt/server/ui/static/lnt_graph.js
+++ lnt/trunk/lnt/server/ui/static/lnt_graph.js
@@ -99,6 +99,10 @@
         tip_body +=  "<b><a href=\"" + meta_data.link + "\">" + meta_data.title + "</a></b></br>";
     }
 
+    if (meta_data.machine) {
+        tip_body += "<b>Machine:</b> " + meta_data.machine + "<br>";
+    }
+
     if (meta_data.test_name) {
         tip_body += "<b>Test:</b> " + meta_data.test_name + "<br>";
     }
Index: lnt/trunk/lnt/server/ui/views.py
===================================================================
--- lnt/trunk/lnt/server/ui/views.py
+++ lnt/trunk/lnt/server/ui/views.py
@@ -955,7 +955,7 @@
 
         data.sort(key=lambda sample: convert_revision(sample[0], cache=revision_cache))
 
-        graph_datum.append((test.name, data, col, field, url))
+        graph_datum.append((test.name, data, col, field, url, machine))
 
         # Get baselines for this line
         num_baselines = len(baseline_parameters)
@@ -1021,9 +1021,9 @@
         # Sort data points according to revision number.
         data.sort(key=lambda sample: convert_revision(sample[0]))
 
-        graph_datum.append((test_name, data, col, field, None))
+        graph_datum.append((test_name, data, col, field, None, machine))
 
-    for name, data, col, field, url in graph_datum:
+    for name, data, col, field, url, machine in graph_datum:
         # Compute the graph points.
         errorbar_data = []
         points_data = []
@@ -1062,6 +1062,7 @@
 
             # Generate metadata.
             metadata = {"label": point_label}
+            metadata["machine"] = machine.name
             metadata["date"] = str(dates[agg_index])
             if runs:
                 metadata["runID"] = str(runs[agg_index])


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D52346.167710.patch
Type: text/x-patch
Size: 1866 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181001/bebb9cf0/attachment.bin>