[PATCH] D51841: [llvm-objcopy] Dwarf decompression support.

[Puyan Lotfi via Phabricator via llvm-commits]

plotfi marked 5 inline comments as done.
plotfi added inline comments.


================
Comment at: test/tools/llvm-objcopy/compress-debug-sections.test:5
+
+# RUN: llvm-objcopy --compress-debug-sections=zlib     %t.o %tz.o
+# RUN: llvm-objcopy --compress-debug-sections=zlib-gnu %t.o %tzg.o
----------------
jhenderson wrote:
> plotfi wrote:
> > jhenderson wrote:
> > > jhenderson wrote:
> > > > plotfi wrote:
> > > > > jhenderson wrote:
> > > > > > As with other tests, this test (or possibly the specific compress and decompress tests) should show that the inputs are not modified when using the specified switch.
> > > > > I don't understand what you mean here. Could you please explain?
> > > > If you look at a lot of our other feature tests, we make a copy of the input before running llvm-objcopy and then compare %t.o against that copy, to show that llvm-objcopy didn't do an in-place modification of the file.
> > > > As with other tests, this test (or possibly the specific compress and decompress tests) should show that the inputs are not modified when using the specified switch.
> > > 
> > > This hasn't been addressed.
> > I dont understand what you mean? Do you mean the decompressed section is the same as original? 
> No. I mean you should look at the examples in the testsuite, such as discard-all.test and do something similar to show that the input file (%t.o) is not modified, by copying it first and comparing it against the copy after you have run llvm-objcopy.
I hope this is what you meant.


Repository:
  rL LLVM

https://reviews.llvm.org/D51841