[PATCH] D35035: [InstCombine] Prevent memcpy generation for small data size

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Sep 30 13:45:34 PDT 2018


lebedev.ri added inline comments.


================
Comment at: lib/Transforms/InstCombine/InstCombineCalls.cpp:133
   assert(Size && "0-sized memory transferring should be removed already.");
-
-  if (Size > 8 || (Size&(Size-1)))
-    return nullptr;  // If not 1/2/4/8 bytes, exit.
+  if (Size & (Size-1))
+    return nullptr; // Not a power of 2.
----------------
Actually, please use `!isPowerOf2_64(Size)`.


https://reviews.llvm.org/D35035





More information about the llvm-commits mailing list