[PATCH] D52532: Pull GetSoftwareBreakpointPCOffset into base class

[Kamil Rytarowski via Phabricator via llvm-commits]

krytarowski added a comment.

In https://reviews.llvm.org/D52532#1250404, @labath wrote:

> In https://reviews.llvm.org/D52532#1246173, @krytarowski wrote:
>
> > I was wondering whether we want to normalize this inside the kernel and always advance the Program Counter.. but it's easier to manage it in userland.
>
>
> I am generally in favour of keeping the kernel simple, particularly when ptrace is concerned. However, there is one difference in behaviour that annoys me. Right now, if an application itself inserts a trap into it's source code, on intel it will be easy to resume it from debugger simply by continuing. OTOH, on arm, the user will have to manually update the PC first. So I am not sure which is better here...


Right now I defer this into future. We still need to fixup PC in kernel debuggers... on the other hand in order to advance the register manually on an arbitrary ISA we might need to guess instruction size. It's better to guess it in userland.


Repository:
  rL LLVM

https://reviews.llvm.org/D52532