[PATCH] D52702: [X86] Standardize floating point assembly comments

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon created this revision.
RKSimon added reviewers: craig.topper, spatel, chandlerc.

Consistently try to use APFloat::toString for floating point constant comments to get rid of differences between Constant / ConstantDataSequential values - it should help stop some of the linux-windows buildbot failures matching NaN/INF etc. as well.

Not sure if this is redundant if/when https://reviews.llvm.org/D37184 lands?


Repository:
  rL LLVM

https://reviews.llvm.org/D52702

Files:
  lib/Target/X86/X86MCInstLower.cpp
  test/CodeGen/X86/2011-20-21-zext-ui2fp.ll
  test/CodeGen/X86/avx-basic.ll
  test/CodeGen/X86/avx-vbroadcast.ll
  test/CodeGen/X86/broadcast-elm-cross-splat-vec.ll
  test/CodeGen/X86/combine-fabs.ll
  test/CodeGen/X86/combine-fcopysign.ll
  test/CodeGen/X86/cvtv2f32.ll
  test/CodeGen/X86/fma-intrinsics-fast-isel.ll
  test/CodeGen/X86/fma_patterns.ll
  test/CodeGen/X86/fma_patterns_wide.ll
  test/CodeGen/X86/fmul-combines.ll
  test/CodeGen/X86/fold-vector-trunc-sitofp.ll
  test/CodeGen/X86/ftrunc.ll
  test/CodeGen/X86/insert-into-constant-vector.ll
  test/CodeGen/X86/packss.ll
  test/CodeGen/X86/pow.ll
  test/CodeGen/X86/pr2656.ll
  test/CodeGen/X86/pr38639.ll
  test/CodeGen/X86/recip-fastmath.ll
  test/CodeGen/X86/recip-fastmath2.ll
  test/CodeGen/X86/select_const.ll
  test/CodeGen/X86/sqrt-fastmath.ll
  test/CodeGen/X86/sse2.ll
  test/CodeGen/X86/subvector-broadcast.ll
  test/CodeGen/X86/unfold-masked-merge-vector-variablemask-const.ll
  test/CodeGen/X86/v4f32-immediate.ll
  test/CodeGen/X86/vec_cast3.ll
  test/CodeGen/X86/vec_fabs.ll
  test/CodeGen/X86/vec_floor.ll
  test/CodeGen/X86/vec_fpext.ll
  test/CodeGen/X86/vec_int_to_fp.ll
  test/CodeGen/X86/vec_ss_load_fold.ll
  test/CodeGen/X86/vec_uint_to_fp-fastmath.ll
  test/CodeGen/X86/vec_uint_to_fp.ll
  test/CodeGen/X86/vector-constrained-fp-intrinsics.ll
  test/CodeGen/X86/vector-shuffle-avx512.ll
  test/CodeGen/X86/vector-shuffle-combining-avx.ll
  test/CodeGen/X86/vector-shuffle-combining-avx2.ll
  test/CodeGen/X86/vector-shuffle-combining-xop.ll
  test/CodeGen/X86/vselect-avx.ll
  test/CodeGen/X86/x86-setcc-int-to-fp-combine.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D52702.167641.patch
Type: text/x-patch
Size: 161265 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180930/ede79719/attachment-0001.bin>