[PATCH] D52693: [LLVM-C] Add an accessor for the kind of a Metadata Node

[Robert Widmann via Phabricator via llvm-commits]

CodaFi added inline comments.


================
Comment at: include/llvm-c/DebugInfo.h:1198
+ */
+LLVMMetadataKind LLVMGetMetadataKind(LLVMMetadataRef Metadata);
+
----------------
whitequark wrote:
> C enums don't have a defined ABI and should never be used in function signatures, because this makes FFI impossible to do correctly without going through something libclang.
So what's the workaround here?  I recognize the ABI concerns given LLVM's stated policy on the C API, but I'm curious to know how this hasn't come up before considering Core.h and DebugInfo.h define and use over 20 different enumerations across their signatures.


Repository:
  rL LLVM

https://reviews.llvm.org/D52693