[PATCH] D52324: [ValueTracking] Allow select patterns to work on FP vectors
Thomas Lively via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Sep 28 14:23:13 PDT 2018
tlively added a comment.
In https://reviews.llvm.org/D52324#1249624, @aheejin wrote:
> If this CL only handles floating point vectors and not integer vectors, I don't think that's a job of this CL to implement the integer part as well, but maybe it's better to add a line of comment that's marked as TODO saying currently in case of vectors only floating points are supported, or something. Otherwise LGTM.
Looking at the code again, I think integer vectors should already be handled ok, so no need for a TODO.
Repository:
rL LLVM
https://reviews.llvm.org/D52324
More information about the llvm-commits
mailing list