[PATCH] D52636: GraphWriter: Provide an API for writing a graph into a specified file
Artem Dergachev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Sep 28 11:10:02 PDT 2018
NoQ added inline comments.
================
Comment at: llvm/include/llvm/Support/GraphWriter.h:339
+ llvm::errs() << "error writing into file" << "\n";
+ return "";
+ }
----------------
george.karpenkov wrote:
> NoQ wrote:
> > This function returns `Filename` on the success branch, should we pass it through here as well?
> This is an error branch. Later on we also return an empty string in case of an error.
Whoops.
https://reviews.llvm.org/D52636
More information about the llvm-commits
mailing list