[PATCH] D52564: [PPC64] Add test for toc-restore on recursive call.

[Sean Fertile via Phabricator via llvm-commits]

sfertile added inline comments.


================
Comment at: test/ELF/ppc64-toc-restore-recursive-call.s:41
+    addi 5, 3, -1
+    mulld 4, 4, 3
+    mr 3, 5
----------------
MaskRay wrote:
> sfertile wrote:
> > MaskRay wrote:
> > > Are these extra operations (addi, mulld, ...) needed to make the test feel more authentic?
> > essentially. Its from one of the unit tests I wrote to figure out how we could have a recursive function call that crossed module boundaries, so I needed some 'testable' behavior.
> And I asked about this because I found that ppc64 tests tend to be verbose while tests of other architectures usually only contain the construction that is relevant in question and very few set up.
> 
> The way other tests are organized make them outstanding what are being tested while I the verbosity has the merit that they feel more natural (the context may help understanding). I was just asking, not really have an opinion on what should be favored...
I appreciate the feedback. I definitely find the context helps my understanding , but can see how it obfuscates what exactly is being tested. I imagine that since I'm typically very familiar with the 'surrounding' extra code I probably tend to underestimate that effect as well :)


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D52564