[PATCH] D52570: [X86] Don't generate BMI BEXTR from X86DAGToDAGISel::matchBEXTRFromAnd
Simon Pilgrim via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Sep 28 09:37:38 PDT 2018
RKSimon added a comment.
In https://reviews.llvm.org/D52570#1248819, @lebedev.ri wrote:
> In https://reviews.llvm.org/D52570#1248811, @RKSimon wrote:
>
> > In the short term I think a fast feature flag (for bdver/btver/znver amd targets) is the way to go
>
>
> Hm, but those *are* all the AMD targets that support BMI.
> Perhaps this can be simplified down to `isAMD()` ?
Please don't - we need to be getting rid of X86ProcFamilyEnum not adding yet more complications to it - handling all those enums is even worse than feature flags.
https://reviews.llvm.org/D52570
More information about the llvm-commits
mailing list