[PATCH] D52558: [PHIElimination] Lower a PHI node with only undef uses as IMPLICIT_DEF

Bjorn Pettersson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 28 09:37:38 PDT 2018


bjope added a comment.

In https://reviews.llvm.org/D52558#1249265, @MatzeB wrote:

> In https://reviews.llvm.org/D52558#1249214, @bjope wrote:
>
> > Minor refactoring/renaming as suggested by Matze.
>
>
> BTW: This is still good to go, no need for further review. (I often approve patches with small issues remaining in cases where I trust the author to address the small issues correctly).


Great, I kind of imagined that it was good to go, but wanted to publish my pre-commit updates anyway (I do not have time to monitor build bots today so I'll commit this later).
Thanks for the review!


Repository:
  rL LLVM

https://reviews.llvm.org/D52558





More information about the llvm-commits mailing list