[PATCH] D52648: [Support] Listing a directory containing dangling symlinks is not an error.
Max Moroz via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Sep 28 09:24:46 PDT 2018
Dor1s added inline comments.
================
Comment at: include/llvm/Support/FileSystem.h:1220-1221
}
// Other members as required by
// C++ Std, 24.1.1 Input iterators [input.iterators]
};
----------------
is this comment still relevant?
================
Comment at: include/llvm/Support/FileSystem.h:1263
+ if (status)
+ type = status->type();
+ // Otherwise broken symlink, and we'll continue.
----------------
Can this `status` be different from the value obtained on line 1259?
Repository:
rL LLVM
https://reviews.llvm.org/D52648
More information about the llvm-commits
mailing list