[PATCH] D52613: [ADT] Change the `IntervalMap` alignment assert for x86 MSVC

Hans Wennborg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 28 05:16:40 PDT 2018


hans added a reviewer: rnk.
hans added a comment.

Hmm, it's strange that we haven't hit this assert before, then. What is causing you to hit it?

At the very least this would need the comment explaining exactly what the ifdef is doing and why.

I think checking for _WIN32 is also not correct. clang-cl will for example 8-byte align both S0 and S1 from your example and maybe MinGW does too (I haven't checked).


Repository:
  rL LLVM

https://reviews.llvm.org/D52613





More information about the llvm-commits mailing list