[PATCH] D52548: Stop instcombining introducing undef's in div/rem instructions.

Neil Henning via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 28 02:43:37 PDT 2018


sheredom marked an inline comment as done.
sheredom added inline comments.


================
Comment at: lib/Transforms/InstCombine/InstCombineVectorOps.cpp:874
+/// the original vector width.
+static bool ShuffleMaskWidens(Value *V, ArrayRef<int> Mask) {
+  Type *Ty = V->getType();
----------------
lebedev.ri wrote:
> I think this should to into `lib/IR/Instructions.cpp`, somewhere around the `ShuffleVectorInst::isIdentityMask()`?
> (`isWideningMask()`)
So I moved it into Instructions.h instead, and called it `increasesLength` because there was an existing method `changesLength` on ShuffleVectorInst so I thought better to match that!


https://reviews.llvm.org/D52548





More information about the llvm-commits mailing list