[PATCH] D52553: [PHIElimination] Update the regression test for PR16508

[Bjorn Pettersson via Phabricator via llvm-commits]

bjope added a comment.

In https://reviews.llvm.org/D52553#1248187, @MatzeB wrote:

> LGTM, thanks! Maybe we can even drop the `.ll` test now?


Original plan was to remove the `.ll` test. Then I read about LiveVariables being deprecated, and since I use livevars it in the new `.mir` test I though that perhaps that test case will be invalid in the future.

Now when I've got the bigger picture about the history regarding LiveVariable vs LiveIntervals in this pass I have this suggestion:

1. I'll remove the `.ll` test case in this patch.
2. I'll add comments new `.mir` test case (above the RUN line), describing that this is a reduced reproducer based on the old `.ll` test case.

Given the information in the `.mir`test (and the commit msg) it should be quite easy to dig up the old `.ll` test case again, if needed in the future, for example if `livevars` is removed.

I'll update the patch according to the above.


Repository:
  rL LLVM

https://reviews.llvm.org/D52553