[PATCH] D52324: [ValueTracking] Allow select patterns to work on vectors in more places

[Thomas Lively via Phabricator via llvm-commits]

tlively added inline comments.


================
Comment at: unittests/Analysis/ValueTrackingTest.cpp:163
+  // pattern.
+  expectPattern({SPF_FMINNUM, SPNB_RETURNS_NAN, false});
+}
----------------
aheejin wrote:
> tlively wrote:
> > aheejin wrote:
> > > How is the third argument `Ordered` determined?
> > By the comparison operator. For example, here `ule` is unordered.
> I thought so first, but other existing test cases don’t seem to follow that rule. So I was wondering if it means something else.
No, but it does default to `false` for integer min/max and patterns that are not min/max, regardless of the comparison mode.


Repository:
  rL LLVM

https://reviews.llvm.org/D52324